add attention up/down blocks for VAE#161
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Aug 9, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Very nice!
One nit: Maybe let's either remove the Cross... prefix from the other attention blocks or add it here - whatever you think is best!
Contributor
Author
|
I didn't put the |
anton-l
approved these changes
Aug 10, 2022
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
Great use of existing modules, very clean :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current VAE does not support having
attentioninencoder/decoderblock as none of the pre-trained models had one. But looking at the stable-diffusion upscaling and RDM confighttps://github.com/pesser/stable-diffusion/blob/693e713c3e72e72b8e2b97236eb21526217e83ad/configs/stable-diffusion/upscaling/upscale-v1-with-f16.yaml#L96
https://github.com/CompVis/latent-diffusion/blob/a506df5756472e2ebaf9078affdde2c4f1502cd4/configs/retrieval-augmented-diffusion/768x768.yaml#L62
It seems some new VAE are going to have
attentioninencoder/decoder. This PR addsAttnDownEncoderBlock2DandAttnUpDecoderBlock2Dto suppor this.